KarpelesLab / slirp / 23944633769

71%

Build Type

push

github

Committed by MagicalTux

Commit Message

Replace VirtualConn/VirtualConn6 with vtcp.Conn

Phase 3.1: Virtual listener connections now use the shared vtcp.Conn
TCP engine instead of the ad-hoc VirtualConn/VirtualConn6 types.

Changes:
- Stack.virtTCP/virtTCP6 maps now hold *vtcp.Conn
- Listener/Listener6 acceptCh changed to chan net.Conn
- SYN handling in handleIPv4/handleIPv6TCP creates vtcp.Conn via
  AcceptSYN(), delegates all TCP to the vtcp engine
- Subsequent packets dispatched via vtcp.Conn.HandleSegment()
- Added frame.go with buildFrame4/buildFrame6 helpers that wrap raw
  TCP segments in IP+Ethernet frames with correct checksums
- Maintenance cleanup uses vtcp.Conn.State() instead of internal fields
- Stack.Close() uses vtcp.Conn.Abort() for cleanup
- Fixed data race: recvBuf now accessed under recvMu consistently
- Tests updated: VirtualConn-specific unit tests removed (covered by
  vtcp/conn_test.go), integration tests retained and adapted

The old VirtualConn/VirtualConn6 types remain in listener.go/listener6.go
as dead code — they will be removed after all migrations complete.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

116 of 167 new or added lines in 5 files covered. (69.46%)

396 existing lines in 4 files now uncovered.

3307 of 4783 relevant lines covered (69.14%)

9.47 hits per line