stacklok / toolhive / 23914145211
65%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 601
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 65.319% (-0.05%) from 65.365%
23914145211

push

github

web-flow 
Restructure MCPTelemetryConfig CRD to nested spec per RFC THV-0023 (#4487)

* Restructure MCPTelemetryConfig CRD to nested spec per RFC THV-0023

The MCPTelemetryConfig spec was using a flat inline embedding of
telemetry.Config which exposed CLI-only fields and didn't match the
nested structure specified in RFC THV-0023.

Restructure to use openTelemetry/prometheus sub-objects:
- spec.openTelemetry: endpoint, headers, sensitiveHeaders,
  resourceAttributes, tracing, metrics, useLegacyAttributes
- spec.prometheus: enabled
- status.referencingWorkloads: structured WorkloadReference
  (kind/namespace/name) replacing bare string list

Update the conversion layer (spectoconfig, controllerutil) to map
the nested CRD types to the flat telemetry.Config at runtime. Add
operator example YAML files for MCPTelemetryConfig and MCPServer
with telemetryConfigRef.

Closes #4262

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Consolidate telemetry examples into single multi-document YAML

Combine MCPTelemetryConfig and MCPServer-with-ref examples into
mcpserver_fetch_otel.yaml as a single apply-able file. Remove the
separate telemetry-configs directory.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address review: gate OTel on Enabled flag, add endpoint CEL validation

Fix two issues from PR review:

- NormalizeMCPTelemetryConfig now gates OTel config on Enabled flag,
  matching ConvertTelemetryConfig behavior. Setting enabled: false
  correctly disables OTLP even if sub-fields are populated.

- Add CEL validation rejecting endpoint when neither tracing nor
  metrics is enabled, catching the misconfiguration at admission
  time instead of failing at proxy runner startup.

Add test cases covering both scenarios.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix CEL rule YAML quoting in CRD manifests

Use single-quoted YAML for the endpoint validation CEL rule to match
the quoting style of ot... (continued)

101 of 138 new or added lines in 5 files covered. (73.19%)

48 existing lines in 8 files now uncovered.

54292 of 83118 relevant lines covered (65.32%)

63.62 hits per line

Uncovered Changes

Lines Coverage ∆ File
20
36.15
 0.35% cmd/thv-operator/api/v1alpha1/zz_generated.deepcopy.go
8
69.38
 0.14% cmd/thv-operator/controllers/mcptelemetryconfig_controller.go
7
80.49
 -5.23% cmd/thv-operator/api/v1alpha1/mcptelemetryconfig_types.go
2
96.3
 -1.46% cmd/thv-operator/pkg/spectoconfig/telemetry.go

Coverage Regressions

Lines Coverage ∆ File
14
74.44
 -5.19% pkg/client/config.go
11
68.42
 -14.47% pkg/client/discovery.go
8
23.56
 -4.6% pkg/client/manager.go
7
82.6
 -0.42% pkg/vmcp/composer/workflow_engine.go
3
71.85
 -1.11% pkg/ignore/processor.go
2
95.68
 -1.44% pkg/vmcp/composer/template_expander.go
2
71.43
 -1.68% pkg/vmcp/k8s/manager.go
1
36.15
 0.35% cmd/thv-operator/api/v1alpha1/zz_generated.deepcopy.go
Jobs
ID Job ID Ran Files Coverage
1 23914145211.1 601
65.32
 GitHub Action Run
Source Files on build 23914145211