tarantool / tarantool / 23895950226

88%

Build Type

push

github

Committed by locker

Commit Message

lua: export checks and metrics to application threads

Note that this commit just exports the metrics module. It doesn't
implement any functionality for collecting or exporting modules set in
application threads via configurable application roles. The latter will
be done later.

The metrics module uses `_G.arg` unconditionally at the top level so
we have to initialize it in application threads. We set it to an empty
table, which should be fine because usage of command-line arguments
doesn't make much sense in application threads. It's acceptable for
the metrics module because the latter uses `arg[0]` to set a metric
label[1]. If it's nil, the label won't be set, which isn't a big deal.
If it turns out to be not enough for some other module, we can always
export the real command-line arguments but for now this doesn't seem
to be necessary.

Closes #12213
Closes #12339

[1]: https://github.com/tarantool/metrics/blob/921efdc18/metrics/psutils/cpu.lua#L11

NO_DOC=unreleased
NO_CHANGELOG=unreleased

Coverage Stats

70586 of 118791 branches covered (59.42%)

2 of 2 new or added lines in 1 file covered. (100.0%)

38 existing lines in 14 files now uncovered.

106137 of 121044 relevant lines covered (87.68%)

1363533.56 hits per line