amazon-aurora / babelfish_extensions / 23888023773

76%

main: 77%

push

github

Fixing memory leaks observed in ASan (#4690)

This commit fixes memory leaks observed when testing with ASan

1. In the function TdsSendRowDescription() , strdup() allocates memory using the system's malloc(), which is completely outside PostgreSQL's memory management. This means the string stored in relMetaDataInfo->partName[1] lives in malloc-heap, not in any PostgreSQL memory context.
By using pstrdup() , it allocates using palloc() inside the current memory context (MessageContext), so it's properly tracked and will be freed when that context is destroyed.

2. Similarly in the function rewrite_if_condition(), strdup uses malloc which is invisible to PostgreSQL's memory management while pstrdup allocates in the current memory context, which gets cleaned up automatically.

Task: BABEL-6422

Authored by : harshdu@amazon.com

3 of 4 new or added lines in 2 files covered. (75.0%)

50792 of 66548 relevant lines covered (76.32%)

396550.76 hits per line