stacklok / toolhive / 23863251809

65%

Build Type

push

github

Committed by web-flow

Commit Message

Add MCPTelemetryConfig controller for lifecycle management (#4480)

* Add MCPTelemetryConfig controller for lifecycle management

The MCPTelemetryConfig CRD API types were added in #4478 but lacked a
controller. This adds a lightweight reconciler following the same pattern
as MCPOIDCConfig (#4462): finalizer management, spec validation (CLI-only
field rejection, sensitive header checks), config hash computation, and
status condition tracking.

Reference tracking, cascade to workloads, and deletion protection are
intentionally deferred until MCPServer gains a TelemetryConfigRef field.

Closes #4249

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address review feedback from Claude

- Move conditionTypeValid constant from mcpoidcconfig_controller_test.go
  to helpers_test.go so both controller test files share it without a
  fragile cross-file dependency.
- Add TestMCPTelemetryConfigReconciler_ConditionOnlyUpdate to cover
  the branch where the config hash is unchanged but the Valid condition
  is missing and needs to be written.
- Narrow RBAC marker on the telemetry controller to get;list;watch;
  update;patch — the controller never creates or deletes the resource.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Regenerate operator manifests for narrowed RBAC

Run task operator-manifests to regenerate the ClusterRole from
kubebuilder markers. The narrowed mcptelemetryconfigs marker now
produces a separate RBAC rule with get;list;watch;update;patch
(no create/delete). Update e2e RBAC assertions to match.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

64 of 93 new or added lines in 2 files covered. (68.82%)

43 existing lines in 6 files now uncovered.

53467 of 81603 relevant lines covered (65.52%)

64.7 hits per line