bitcoindevkit / rust-esplora-client / 23863012434

89%

Build Type

push

github

Committed by luisschwab

Commit Message

Merge bitcoindevkit/rust-esplora-client#176: Roll a custom `TestEnv` and drop `lazy_static`

<a class=hub.com/bitcoindevkit/rust-esplora-client/commit/5748132b2d80aef0c98d4421aaf6b17b4e1b1f11">5748132b2<a href="https://github.com/bitcoindevkit/rust-esplora-client/commit/f115da2b79e027d934b869b445d3562a4b7e2a5b"> refactor(test): properly assert for HTTP headers (Leonardo Lima)
<a class="double-link" href="https://github.com/bitcoindevkit/rust-esplora-client/commit/ed9d7ad1747c6b0fedd9f22b2aa3195e61dd7f5a">ed9d7ad17</a><a href="https://github.com/bitcoindevkit/rust-esplora-client/commit/f115da2b79e027d934b869b445d3562a4b7e2a5b"> feat(test): roll a custom `TestEnv` and drop `lazy_static` (Luis Schwab)
</a><a class="double-link" href="https://github.com/bitcoindevkit/rust-esplora-client/commit/b6bb968a7ae3643a8e6a3ffb503fb59381e899b2">b6bb968a7</a> chore(ci): fix pinning for 1.75.0 MSRV (Luis Schwab)

Pull request description:

  Closes #149

  Implement a custom `TestEnv`, which is instantiated per-test and fixes the un-dropped `bitcoind` issue. This also allows running tests with more than 1 thread, since they no longer share `bitcoind` and `electrsd` instances.

  Also adds helpers to fetch externally sourced addresses, fixing the issue where `bitcoind`'s wallet would send change outputs to it's own wallet address, which would mess with `test_get_scripthash_stats`.

  The `test` recipe and CI job are updated to now use 16 threads.

ACKs for top commit:
  oleonardolima:
    ACK 5748132b2d80aef0c98d4421aaf6b17b4e1b1f11

Tree-SHA512: 5143abc8e0743af3f804bdd2f8bde67c203

Run Details

330 of 331 new or added lines in 1 file covered. (99.7%)

2 existing lines in 2 files now uncovered.

1503 of 1694 relevant lines covered (88.72%)

11.61 hits per line