Alan-Jowett / sonde / 23861000511

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix: phone builds complete PEER_REQUEST frame, node just relays (#495) (#615)

* fix: phone builds complete PEER_REQUEST frame, node just relays (#495)

The phone (pairing tool) builds the entire ESP-NOW PEER_REQUEST frame
including header, AES-256-GCM ciphertext, and tag — encrypted with
phone_psk. The node stores and forwards this blob verbatim.

Fixes:
- ble-pairing-protocol.md: node doesn't need \phone_psk\
- sonde-pair: \ncrypt_pairing_request_aead\ builds complete frame
- sonde-node: PEER_REQUEST just transmits stored blob
- sonde-gateway: \process_frame_aead\ accepts PEER_REQUEST

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address review findings: AEAD validation, shared PairingRequest parser, PSK zeroization

- uild_peer_request_frame_aead: validate with decode_frame_aead and
  check msg_type == MSG_PEER_REQUEST instead of length-only checks
- peer_request_exchange_aead: use decoded header nonce instead of manual
  byte-offset slicing
- Extract shared parse_pairing_request() helper used by both HMAC and
  AEAD handle_peer_request paths to prevent drift
- Keep reference to matched PhonePskRecord in AEAD handler instead of
  copying PSK out of \Zeroizing\ wrapper into plain \[u8; 32]\
- Fix double \set_early_wake_flag()\ call — call once and log errors
- Add happy-path AEAD PEER_REQUEST integration test that registers a
  phone PSK, constructs a properly nested encrypted frame, and verifies
  the gateway returns a PEER_ACK decryptable with \
ode_psk\
- Add test for wrong \msg_type\ rejection in \uild_peer_request_frame_aead\

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: remove unused Sha256Provider import in aead_engine test

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Validate key_hint derived from PSK in both HMAC and AEAD pairing paths

HMAC path: verify that
ode_key_hint from the CBOR payload AND the
frame header both match the canonical derivation fr... (continued)

Coverage Stats

346 of 370 new or added lines in 4 files covered. (93.51%)

181 existing lines in 6 files now uncovered.

26912 of 31480 relevant lines covered (85.49%)

136.09 hits per line