NVIDIA / holodeck / 23860968050

48%

push

github

fix: harden error handling and add SSH keepalive for v0.3.4 (#772)

* fix: handle InvalidInternetGatewayID.NotFound in IGW detach step

The detach retry block in deleteInternetGateway only checked for
Gateway.NotAttached. When the IGW was already deleted, DetachInternetGateway
returned InvalidInternetGatewayID.NotFound, which was retried up to
maxRetries times. Now both conditions are treated as success via the
new isAlreadyDetachedError helper.

Ref: NVIDIA/holodeck#771
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: handle NotFound errors in NLB/listener/target-group deletion

deleteNLB, deleteListener, and deleteTargetGroup had no NotFound
error handling. If any resource was already deleted, errors would
propagate instead of being treated as success. Added helper functions
isNLBNotFoundError, isTargetGroupNotFoundError, isListenerNotFoundError
and applied them to all delete and describe paths.

Ref: NVIDIA/holodeck#771
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: add SSH keepalive and handshake timeout to prevent session drops

Long-running remote commands (kubeadm init, ~10-20 min) were failing
with ExitMissingError because network middleboxes drop idle TCP
connections. Added:
- 15s handshake timeout on ssh.ClientConfig.Timeout (for ssh.Dial)
- 15s deadline on net.Conn before ssh.NewClientConn (for transport path)
- 30s keepalive interval via SSH global requests (startKeepalive)

The keepalive goroutine self-terminates when the client is closed.

Ref: NVIDIA/holodeck#771
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: suppress NotFound warnings in cleanup deleteInternetGateways

When the periodic cleanup job encounters an IGW that is already gone
(InvalidInternetGatewayID.NotFound) or already detached
(Gateway.NotAttached), the warning is now silently skipped instead of
logging a misleading failure message.

Signed-off-by: Carlos Eduardo Arango Gutierrez <edu... (continued)

46 of 72 new or added lines in 4 files covered. (63.89%)

5270 of 11032 relevant lines covered (47.77%)

0.53 hits per line