stacklok / toolhive / 23859518678

65%

Build Type

push

github

Committed by web-flow

Commit Message

Add status conditions to MCPToolConfig CRD (#4474)

* Add status conditions to MCPToolConfig CRD

MCPToolConfig was the only CRD in the operator without standard
Kubernetes conditions in its status. This adds a Conditions field
and sets a Valid condition during reconciliation, bringing it in
line with MCPServer, EmbeddingServer, and MCPExternalAuthConfig.

Closes #4472

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Avoid leaking errors into condition messages

Keep condition messages user-facing and static. The underlying error
is already logged via logger.Error and returned for requeue.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Add integration tests for MCPToolConfig controller

Verify condition-setting, hash tracking, referencing server updates,
and finalizer-based deletion protection using envtest.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Defer hash persist until after server lookup succeeds

Move ConfigHash and ObservedGeneration writes after the
findReferencingMCPServers call so a transient failure requeues
into handleConfigHashChange and MCPServer annotation updates
are not permanently skipped. Also regenerate CRD API docs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

21 of 35 new or added lines in 2 files covered. (60.0%)

11 existing lines in 3 files now uncovered.

53363 of 81479 relevant lines covered (65.49%)

63.51 hits per line