stacklok / toolhive / 23857036405

65%

Build Type

push

github

Committed by web-flow

Commit Message

Add migration window fallback to ScopedProvider (#4386)

* Surface bare-key backend errors in migration fallback

Previously, if the bare-key fallback lookup returned a real backend
error (connection failure, auth error), the error was silently discarded
and the caller received the original scoped-key "not found" error,
making backend problems invisible.

Now we distinguish the two cases:
- bare key not found → fall through to the original scoped-key error
- bare key lookup fails with a real error → surface it wrapped so the
  caller can diagnose the root cause

Also adds a doc comment to IsNotFoundError documenting which backend
error message forms it matches, so future backend authors know the
contract.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix lintint

* Introduce ErrSecretNotFound sentinel and update IsNotFoundError

Define a package-level ErrSecretNotFound sentinel so built-in backends
return a typed error that callers can check with errors.Is rather than
relying on string matching.

Update EncryptedManager and EnvironmentProvider to wrap the sentinel
with %w. Update IsNotFoundError to prefer errors.Is and keep substring
matching only as a legacy fallback for third-party backends (e.g.
1Password SDK) that cannot wrap the sentinel. Remove the now-redundant
strings.Contains call in ValidateEnvironmentProvider.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Coverage Stats

14 of 14 new or added lines in 5 files covered. (100.0%)

12 existing lines in 2 files now uncovered.

53346 of 81322 relevant lines covered (65.6%)

64.59 hits per line