NVIDIA / holodeck / 23818694564

46%

main: 48%

push

github

fix: revoke cross-referencing SG rules before deletion in cleanup

Security groups that reference each other (e.g., CP SG allows traffic
from Worker SG and vice versa) cannot be deleted due to AWS
DependencyViolation errors. Revoke all ingress/egress rules before
attempting deletion to break the circular dependency.

This fixes the periodic cleanup failing on 2 remaining VPCs in
us-west-1 that had cross-referencing CP/Worker security groups.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

14 of 26 new or added lines in 2 files covered. (53.85%)

5009 of 10970 relevant lines covered (45.66%)

0.51 hits per line