Mellanox / network-operator / 23810671614
63%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 63
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 62.086% (+0.3%) from 61.776%
23810671614

push

github

web-flow 
feat: add NicNodePolicy CRD for per-node-group DOCA driver management (#2279)

Add comprehensive support for heterogeneous clusters where different
node
groups require different DOCA driver versions via NicNodePolicy (NNP).

Webhook validation:
- Section conflict detection prevents same component (ofedDriver,
  rdmaSharedDevicePlugin, sriovDevicePlugin) in both NCP and NNP
- Node selector overlap detection rejects NNPs targeting the same nodes
- Runtime overlap re-check catches drift from node re-labeling

DaemonSet isolation:
- Unique DS/ConfigMap names via NameSuffix (e.g. mofed-...-gpu-nodes-ds)
- ds-owner label on both DaemonSet and pod template for ownership
tracking
- Node discovery scoped by NNP nodeSelector to avoid phantom DaemonSets

mofed.wait label management:
- NNP controller sets mofed.wait based on OFED pod readiness on its
nodes
- NCP fallback path excludes NNP-managed nodes from label cleanup
- NNP deletion keeps mofed.wait=true while pods terminate, then
converges

DOCA driver upgrade:
- Per-NNP upgrade state managers with isolated requestor IDs
- NCP upgrade cleanup scoped to exclude NNP-managed nodes

Controller deduplication:
- Shared NicPolicyCR status accessors for polymorphic status updates
- Extracted helpers: requeueWithDelay, updatePolicyCRStatus,
  setupOFEDCatalog, watchStateSources
- ResolveNodesByPolicy as single source of truth for node resolution

Also adds heterogeneous-cluster-support.md with architecture docs
and mermaid flowcharts.

804 of 1193 new or added lines in 27 files covered. (67.39%)

22 existing lines in 7 files now uncovered.

4834 of 7786 relevant lines covered (62.09%)

43.7 hits per line

Uncovered Changes

Lines Coverage ∆ File
146
35.85
 -12.76% controllers/upgrade_controller.go
48
80.49
 api/v1alpha1/validator/nicpolicy_webhook.go
45
60.18
 controllers/mofed_wait_labels.go
43
45.4
 2.13% api/v1alpha1/zz_generated.deepcopy.go
42
69.12
 controllers/nicnodepolicy_controller.go
13
0.0
 0.0% main.go
10
81.48
 6.02% controllers/nicclusterpolicy_controller.go
9
78.57
 api/v1alpha1/nicnodepolicy_types.go
7
71.32
 0.25% pkg/state/factory.go
7
73.19
 -0.02% pkg/state/state_ofed.go
5
95.28
 pkg/policyoverlap/overlap.go
3
92.65
 -0.46% api/v1alpha1/nicclusterpolicy_types.go
3
95.52
 controllers/nic_policy_helpers.go
3
71.43
 0.0% pkg/state/state_rdma_shared_device_plugin.go
2
62.67
 3.29% controllers/predicate.go
2
71.43
 0.0% pkg/state/state_sriov_dp.go
1
83.6
 -0.1% pkg/state/state_skel.go

Coverage Regressions

Lines Coverage ∆ File
7
86.05
 -5.81% controllers/hostdevicenetwork_controller.go
4
45.4
 2.13% api/v1alpha1/zz_generated.deepcopy.go
4
35.85
 -12.76% controllers/upgrade_controller.go
2
88.46
 -2.56% controllers/macvlannetwork_controller.go
2
75.68
 -2.7% pkg/state/state_hostdevice_network.go
2
83.6
 -0.1% pkg/state/state_skel.go
1
81.48
 6.02% controllers/nicclusterpolicy_controller.go
Jobs
ID Job ID Ran Files Coverage
1 23810671614.1 63
62.09
 GitHub Action Run
Source Files on build 23810671614