stacklok / toolhive-studio / 23804882346

60%

push

github

fix(registry): show secrets and env vars sections when registry has none pre-defined (#1891)

* fix: show secrets and env vars sections for registry servers with no pre-defined vars

When a registry server has no secrets or env vars defined in the
registry metadata, the install form now shows the dynamic add
components instead of hiding the sections entirely.

Closes #1876

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: make env var value optional in FormWithEnvVars type

Remove unsafe type cast by making value optional in FormWithEnvVars,
matching the registry schema where env var values are optional.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: allow adding custom secrets and env vars for all registry servers

- Always show "Add secret" and "Add environment variable" buttons in the
  registry install form, both for servers with and without pre-defined
  env vars
- Pre-defined rows keep their existing UX (read-only labels, tooltips,
  required indicators)
- Custom rows appear below with editable name/value inputs and remove button
- Relax schema name validation to accept any string, not just pre-defined
  literal names from the registry
- Add 6 tests covering add/remove/submit of custom entries

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: restore htmlFor on section labels for pre-defined entries

The Label elements for Secrets and Environment Variables sections need
htmlFor pointing to the first input when pre-defined entries exist,
otherwise getByLabelText in tests can't find the associated form control.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

2987 of 5227 branches covered (57.15%)

Branch coverage included in aggregate %.

24 of 26 new or added lines in 2 files covered. (92.31%)

4887 of 7802 relevant lines covered (62.64%)

127.88 hits per line