OpenCyphal-Garage / cy / 23800370046

100%

main: 100%

push

github

Fix uint16 overflow in pin parsing and replace unreachable code with assert

The decimal accumulator in name_consume_pin_suffix() was uint16_t, so
multiply-then-cast could wrap into the valid [0, 8191] range before the
bounds check (e.g. #65536 accepted as pin 0). Widen to uint32_t.

In cy_name_join(), the separator-overflow check is provably unreachable
(len > 0 ∧ len < dest_size ⇒ len + 1 ≤ dest_size); replace with assert.

Regression tests cover wrap-around values through both the internal
parser and the public cy_name_resolve API.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

486 of 486 branches covered (100.0%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

2140 of 2144 relevant lines covered (99.81%)

340983.94 hits per line