safe-global / safe-client-gateway / 23799998584

90%

Build Type

push

github

Committed by web-flow

Commit Message

fix(circuit-breaker): fix request tracking in HALF_OPEN state (#2991)

## Summary

Fix two concurrency-related bugs in the circuit breaker where in-flight requests cause incorrect behavior:
1. In HALF_OPEN state, completed test requests don't free their slot, blocking new requests even after the downstream service has recovered.
2. In OPEN state, late-arriving failures from in-flight requests inflate the failure count past the threshold (e.g. `25/20`).

## Changes

- **`recordSuccess`**: Decrement `halfOpenRequestCounts` when a request completes successfully in HALF_OPEN state, freeing the slot for new test requests.
- **`recordFailure`**: Early return when the circuit is already OPEN, preventing in-flight requests from recording redundant failures.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Coverage Stats

3219 of 4032 branches covered (79.84%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

3 existing lines in 3 files now uncovered.

15160 of 16473 relevant lines covered (92.03%)

573.85 hits per line