grid-x / ocpp-go / 23795973618

89%

gridx_extensions: 89%

Build Type

push

github

Committed by mkrafeld

Commit Message

fix(ocppj): guard DefaultClientDispatcher.SendRequest against send-on-closed-channel panic

Stop() previously closed requestChannel, so a concurrent SendRequest call
racing the close would panic at 'd.requestChannel <- true'. This mirrors
the same bug the ServerDispatcher already had fixed via stoppedC.

Changes:
- Add stoppedC chan struct{} to DefaultClientDispatcher
- Start(): initialise stoppedC alongside requestChannel (under mutex)
- Stop(): close stoppedC instead of requestChannel; set requestChannel=nil
  so IsRunning() returns false immediately
- SendRequest(): capture rc/sc under RLock, return error if rc==nil, then
  use select{case rc<-true / case <-sc} so a concurrent Stop() returns
  "client stopped" instead of panicking
- messagePump(): add case <-d.stoppedC as primary exit path

Coverage Stats

22 of 29 new or added lines in 1 file covered. (75.86%)

4 existing lines in 1 file now uncovered.

6542 of 7360 relevant lines covered (88.89%)

13.5 hits per line