tarantool / luajit / 23790075695

93%

Build Type

push

github

Committed by Buristan

Commit Message

Prevent false positive sanitizer warning in unpack().

Reported by Sergey Bronnikov.

(cherry picked from commit f322ecb51)

The UndefinedBehaviour sanitizer produces a runtime warning when
INT_MAX is passed to `unpack()` as index `i`. This happens because
`i` in lj_cf_unpack() was incremented before the checking loop
invariant and this leads to a signed integer overflow. The patch
fixes the issue by moving index incrementation in the separate
statement from the loop invariant check.

Sergey Bronnikov:
* added the description and the test for the problem

Part of tarantool/tarantool#12134

Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>

Coverage Stats

5717 of 6055 branches covered (94.42%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

6 existing lines in 1 file now uncovered.

21834 of 23546 relevant lines covered (92.73%)

3973390.9 hits per line