stacklok / toolhive / 23749352567

65%

Build Type

push

github

Committed by web-flow

Commit Message

Treat PID 0 as dead in supervisor liveness check (#4431)

Treat PID 0 as dead in isSupervisorProcessAlive

During transport restart, ResetWorkloadPID sets process_id to 0 in
the status file. isSupervisorProcessAlive only checked for an error
from GetWorkloadPID, so (0, nil) was treated as a live supervisor.
This caused thv restart to silently no-op during the transient
window where PID is 0.

Fixes #4429

Signed-off-by: Greg Katz <gkatz@indeed.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Muhammad Amir Ejaz <amir@stacklok.com>

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

12 existing lines in 3 files now uncovered.

52857 of 80659 relevant lines covered (65.53%)

62.67 hits per line