stacklok / toolhive / 23747991487

65%

Build Type

push

github

Committed by web-flow

Commit Message

Respect global config for OTel tracing and metrics enabled (#4326)

* Respect global config for OTel tracing/metrics

thv config otel set-tracing-enabled false was silently ignored by
thv run because getTelemetryFromFlags had no fallback for these
two fields, and buildRunConfig bypassed the fallback entirely for
the proxy runner config. Users could not globally disable telemetry
without passing CLI flags on every invocation.

Fixes #4323

Signed-off-by: Greg Katz <gkatz@indeed.com>

* Add test for disabled-signals telemetry path

Cover the createTelemetryConfig early-return when both
tracing and metrics are disabled with the endpoint still
configured.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Greg Katz <gkatz@indeed.com>

* Address review feedback on OTel config PR

Fix unset guard to check nil only, not nil-or-false,
so users can unset an explicit false value. Return a
struct from getTelemetryFromFlags instead of 8 positional
values. Default tracing/metrics to false when telemetry
config is nil to avoid fragile fallback to runFlags.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Greg Katz <gkatz@indeed.com>

---------

Signed-off-by: Greg Katz <gkatz@indeed.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Muhammad Amir Ejaz <amir@stacklok.com>

Coverage Stats

22 of 57 new or added lines in 2 files covered. (38.6%)

4 existing lines in 2 files now uncovered.

52831 of 80619 relevant lines covered (65.53%)

64.85 hits per line