extphprs / ext-php-rs / 23741511588

66%

master: 66%

Build Type

Pull #707

github

Committed by ptondereau

Commit Message

fix(memory): eliminate module definition memory leak

Store the ModuleEntry in a static (StaticModuleEntry) instead of
Box::into_raw, mirroring how C extensions use a static zend_module_entry.
Free all secondary heap allocations (name, version, functions, arg_info,
class-name pointers) during MSHUTDOWN via cleanup_module_allocations().

Reduces valgrind-reported leaks by ~44% (10KB / 225 blocks) on the test
extension. Remaining leaks are from class registration — a separate concern.

Closes #540

Pull Request Pull Request #707: fix(memory): eliminate module definition memory leak

Run Details

43 of 59 new or added lines in 1 file covered. (72.88%)

54 existing lines in 5 files now uncovered.

8108 of 12301 relevant lines covered (65.91%)

31.9 hits per line