sebnitu / vrembem / 23725570480

91%

main: 100%

Build Type

push

github

Committed by web-flow

Commit Message

Improve the modal component and config module integration (#2726)

This PR primarily refactors the modal component to the new CSS variable pattern, applies the config module for sass level configurations and cleans up the modal collection API. The CSS variable pattern applies references along with sensible fallbacks. This replaces the initial Sass variable solution for component customization. The documentation has also been updated to reflect these changes.

This PR also addresses overscrolling visual issues by adding a new scrollable container element for dialogs, drawers and modals. This takes the form of `[component]__container` which separates content scrolling from the dialog’s background and border styles, preventing overscroll visual issues. Style output is implemented using the new `scroll-flex` mixin.

Lastly, this PR refactors the backdrop (previously named "screen") styles and implementation for both modal drawers and the modal components. This is done using the new `backdrop` mixin.

**Additional changes**

- `docs`: Applies Vrembem Drawer more directly into doc's layout sidebar and aside components.
- `docs`: Fixes popover styles on code example copy buttons.
- `docs`: Converted the use of singular variable names to plural when storing the reference to a collection.
- `docs`: Fix and improve various styles in documentation.
- `core`: Deprecated `scroll-box` in favor of `overflow-hidden` utility.
- `core`: `StackArray.top` returns `undefined` instead of `null` when no modals are open.
- `drawer`: Refactored and removed unnecessary styles of drawer.
- `modal`: Refactored and removed unnecessary styles of modal.
- `modal`: Removed dispatching custom events in favor of collection event system.
- `vrembem`: Restored the `./sass` entry as it's used when importing Sass in the JS context.

Run Details

583 of 664 branches covered (87.8%)

Branch coverage included in aggregate %.

7 of 8 new or added lines in 6 files covered. (87.5%)

1 existing line in 1 file now uncovered.

941 of 1009 relevant lines covered (93.26%)

31.05 hits per line