bluedynamics / zope.interface / 23723487425

99%

master: 99%

push

github

Replace all PyDict_GetItem with exception-safe alternatives

PyDict_GetItem silently swallows ALL exceptions from __hash__/__eq__,
causing isOrExtends() to return False instead of raising TypeError for
unhashable objects, and silently swallowing MemoryError. CPython 3.14
now warns about this at runtime.

Changes:
- SB_extends (line 335): PyDict_GetItem -> PyDict_Contains
- IB__adapt__ (line 795): PyDict_GetItem -> PyDict_Contains
- IB__call__ (line 906): PyDict_GetItem on tp_dict -> PyDict_Contains
  with PyType_GetDict() on 3.13+ for free-threading safety
- Polyfill _PyDict_GetItemRef: PyDict_GetItem -> PyDict_GetItemWithError

PyDict_Contains is also faster: it skips the PyErr_Fetch/PyErr_Restore
error-state dance that PyDict_GetItem does on every call (~12 memory
operations saved per call on the hottest path).

Fixes #357

2445 of 2474 branches covered (98.83%)

Branch coverage included in aggregate %.

32 of 32 new or added lines in 1 file covered. (100.0%)

12193 of 12303 relevant lines covered (99.11%)

7.92 hits per line