Alan-Jowett / sonde / 23715015336

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat(gateway): fix logging test + implement handler config (GW-1401-GW-1406) (#572)

* fix(gateway): fix broken T-1308 logging test compilation

Add \uild_app_data\ method and \GatewayMessage\ import to the logging
test's \TestNode\. Add missing \hex\ dependency for \alidate_program_hash\
in admin.rs. Run \cargo fmt\ to fix formatting in admin.rs and
sqlite_storage.rs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(gateway): fix T-1308 test APP_DATA sequence

Add GW-1308 operational logging (APP_DATA received, handler matched,
handler invoked, handler replied, handler exited with code) to engine.rs
and handler.rs. Fix logging.rs test: add missing GatewayMessage/MSG_APP_DATA
imports, add build_app_data helper, add working_dir field, and improve
Windows Python detection to fall back from py to python3/python.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(gateway): address PR #572 review findings

- Fix empty handler cache on legacy bundle import
- Add safe hex parsing with validation in handler_record_to_config
- Fix replace_handlers atomicity documentation
- Assert on add_handler results in tests
- Remove unused hex dependency
- Fix case-sensitivity comment
- Flatten multi-matcher configs on import
- Handle invalid JSON and negative timeouts in SQLite storage

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(gateway): address PR #572 review findings (iteration 2)

- Skip invalid handler records instead of fallback to empty hash
  (prevents silent misconfiguration hiding storage corruption)
- Add ASCII guard to `validate_program_hash()` before byte-index
  slicing to prevent panics on non-ASCII UTF-8 input (GW-1402)
- Use `i64::try_from()` instead of `as i64` for `reply_timeout_ms`
  to catch overflow instead of silent wrapping (GW-1401)
- Guard `ph_hex` allocation with `tracing::enabled!()` in
  `route_app_data()` and `handle_app_data()` to avoid heap
  allocation... (continued)

Coverage Stats

195 of 306 new or added lines in 9 files covered. (63.73%)

2 existing lines in 2 files now uncovered.

23432 of 27395 relevant lines covered (85.53%)

154.52 hits per line