woblerr / gpbackman / 23708479011

46%

master: 46%

Pull #41

github

Fix panic: send on closed channel.
The function used a single errCh channel shared between the directory
existence check phase and the delete phase. After the check phase
completed, errCh was closed via sync.Once. When the delete phase
encountered an SSH error, deleteBackupDirOnSegments attempted to send
to the already-closed channel, causing a panic.
The bug is triggered when SSH succeeds for "test -d" but fails for
"rm -rf" (e.g. connection drop). Hard to hit in practice since rm -rf rarely
fails, which is why it went unnoticed.
Fix: use separate channels (checkErrCh, deleteErrCh) for each phase.
Each channel is closed with a plain close() after wg.Wait(), which is
safe since all goroutines have finished. sync.Once is removed as it is
no longer needed.

9 of 9 new or added lines in 1 file covered. (100.0%)

961 of 2083 relevant lines covered (46.14%)

1.17 hits per line