kubeovn / kube-ovn / 23706494165

26%

push

github

fix(controller): handle missing logical switch in handleMcastQuerierChange (#6542)

* fix(controller): return error when logical switch not found in handleMcastQuerierChange

When disabling multicast snoop, handleMcastQuerierChange silently
returned nil if the logical switch did not exist (err==nil && len==0),
causing the caller to skip multicast cleanup. Split the combined
condition into two separate checks so a missing logical switch now
returns an explicit error. Added unit tests covering all success and
failure paths for both enable and disable branches.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(controller): skip cleanup gracefully when logical switch not found

When the logical switch is already gone, multicast cleanup is
unnecessary. Return nil with a warning instead of an error to avoid
infinite requeue by the work queue.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

5 of 5 new or added lines in 1 file covered. (100.0%)

13534 of 55700 relevant lines covered (24.3%)

0.28 hits per line