Azure / karpenter-provider-azure / 23678969357

93%

main: 94%

Pull #1595

github

fix: pass CreationTimestamp explicitly instead of reading from request template

After #1468 moved CreationTimestamp from a client-side tag to server-side
Status.CreationTimestamp, BuildNodeClaimFromAKSMachineTemplate still read
it from the template object (the PUT request body). The template never has
Status — it's set server-side. This made CreationTimestamp always zero on
the NodeClaim returned by Create().

The bug was masked in tests because the fake's BeginCreateOrUpdate shares
the Properties pointer between the caller's template and the fake's
internal copy. When the fake sets Status.CreationTimestamp via
setDefaultMachineValues, it accidentally mutates the caller's template
through the shared pointer — making tests pass for the wrong reason.

Fix both issues:
- Add CreationTimestamp field to AKSMachinePromise and populate it from
  the GET response (gotAKSMachine) which has the server-side Status.
  Pass it as an explicit parameter to BuildNodeClaimFromAKSMachineTemplate
  instead of reading from the template.
- Deep-copy Properties in the fake's BeginCreateOrUpdate to match real
  SDK behavior (HTTP serialization breaks pointer sharing), preventing
  the side-effect from masking future bugs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

16 of 17 new or added lines in 4 files covered. (94.12%)

59199 of 63369 relevant lines covered (93.42%)

0.95 hits per line