medplum / medplum / 23673084387

92%

main: 92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(client/subscription): prevent React lifecycles from tracking unused WebSocket subs (#8723)

* fix(fhircast): update topic key expiry upon access

Signed-off-by: Derrick Farris <derrick@medplum.com>

* wip(client/subscription): initial testing

Signed-off-by: Derrick Farris <derrick@medplum.com>

* wip(client/subscription): seems like 80% there

Signed-off-by: Derrick Farris <derrick@medplum.com>

* [autofix.ci] apply automated fixes

* wip(client/subscription): seems a lot better, needs cleanup

Signed-off-by: Derrick Farris <derrick@medplum.com>

* fix(subscription): don't unbind since we haven't bound yet

Signed-off-by: Derrick Farris <derrick@medplum.com>

* fix(provider): recomment baseUrl

Signed-off-by: Derrick Farris <derrick@medplum.com>

* fix(getwsbindingtoken): fix token lifetime

Signed-off-by: Derrick Farris <derrick@medplum.com>

* fix(client/subscription): fix tests

Signed-off-by: Derrick Farris <derrick@medplum.com>

* refactor(subscription): rely on GC rather than separate map

Signed-off-by: Derrick Farris <derrick@medplum.com>

* cleanup(SubscriptionManager): rm unnecessary `hasPendingUnbinds()`

Signed-off-by: Derrick Farris <derrick@medplum.com>

* cleanup(provider): recomment `baseUrl`

Signed-off-by: Derrick Farris <derrick@medplum.com>

* refactor(SubscriptionManager): use `getAllEntries` fn

Signed-off-by: Derrick Farris <derrick@medplum.com>

* cleanup(SubscriptionManager): invert check in `removeCriteria`

Signed-off-by: Derrick Farris <derrick@medplum.com>

* test(subscription): fix client test

Signed-off-by: Derrick Farris <derrick@medplum.com>

---------

Signed-off-by: Derrick Farris <derrick@medplum.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Coverage Stats

17971 of 20407 branches covered (88.06%)

Branch coverage included in aggregate %.

94 of 97 new or added lines in 2 files covered. (96.91%)

4 existing lines in 1 file now uncovered.

32653 of 34491 relevant lines covered (94.67%)

14531.14 hits per line