openwisp
/
openwisp-controller
/
23672556336
99%
master: 99%
master: 99%
|
Ran
|
Jobs
1
|
Files
120
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 98.61% (+0.02%) from 98.595%
push
github
nemesifier[fix] Fixed duplicate template entries in Device admin Bug: The JS logic in relevant_templates.js assumed that the last `ul.sortedm2m-items` element belonged to the empty inline form used by Django admin formsets. This assumption breaks when the user does not have permission to add Config objects: in that case the ConfigInlineAdmin does not render the empty form. As a result, both selectors ended up referencing the same list and the script appended template elements twice to the same `sortedm2m` list, causing duplicate entries and issues when saving the form. Fix: Select the empty form container explicitly using `#config-empty ul.sortedm2m-items` instead of relying on the last occurrence of `ul.sortedm2m-items`. This ensures the logic works correctly regardless of whether the empty inline form is rendered. [backport 1.2] (cherry picked from commit b73e83ad2)
6526 of 6618 relevant lines covered (98.61%)
11.83 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | python- - 23672556336.1 | 120 |
98.61 |
GitHub Action Run |
