Alan-Jowett / sonde / 23670482496

82%

push

github

fix(admin): restore identity, phone PSKs, and handler configs on import (#536)

* fix(admin): restore identity, phone PSKs, and handler configs on import

\import_state\ called \decrypt_state()\ which discards gateway identity,
phone PSK registrations, and handler routing configs from the decrypted
bundle.  Switch to \decrypt_state_full()\ and restore all five components:

  1. Nodes + programs via existing \eplace_state()\
  2. Gateway identity via \store_gateway_identity()\
  3. Phone PSKs via clear-then-store
  4. Handler configs via interior-mutable \RwLock\ field update

The \handler_configs\ field is changed from \Vec<HandlerConfig>\ to
\RwLock<Vec<HandlerConfig>>\ so \import_state\ (\&self\) can write it.

Also fixes a stale doc comment on \xport_state\ that incorrectly
claimed handler configs were excluded from the export bundle.

Adds integration test \	0810_import_state_restores_identity_phones_and_handlers\.

Fixes #521

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: clarify import_state doc for conditional identity restore

Address review feedback: identity is only restored when present in the
bundle (older-format bundles may omit it).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: update specs for full-state import_state restore

- GW-0805: acceptance criteria now requires all state components
  (nodes, programs, identity, phone PSKs, handler configs)
- GW-1001: description and criteria enumerate all five components
- T-1005b: new test case verifying identity, phone PSKs, and
  handler configs survive import round-trip
- Traceability table updated for GW-0805 and GW-1001

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: clarify handler config doc comment and assert issued_at in test

- Update import_state doc comment to clarify that handler config
  update only affects AdminService's stored copy for subsequent
  export_state calls, not the live han... (continued)

7 of 49 new or added lines in 3 files covered. (14.29%)

22805 of 26645 relevant lines covered (85.59%)

158.74 hits per line