Alan-Jowett / sonde / 23663272673

82%

push

github

feat(admin): verbose Prevail verification failure diagnostics (#531)

* feat(admin): verbose Prevail verification failure diagnostics

Extract per-instruction diagnostic notes from Prevail's forward-analysis
stage (\AnalysisResult.invariants[label].error\) in addition to unmarshal
notes. Previously only unmarshal notes were collected, which are typically
empty for forward-analysis failures, resulting in a bare
\program X failed verification\ message with no actionable detail.

Changes:

- **program.rs**: After \wd_analyzer::analyze\ fails, iterate
  \esult.invariants\ to collect \VerificationError\ entries and include
  them as newline-separated diagnostics in the error message.

- **main.rs**: Add \--verbose\ / \-v\ global flag. Without it, only the
  summary line of a gRPC error is shown. With it, the full multi-line
  verifier diagnostic is displayed. Also downcast \	onic::Status\ errors
  to show the message directly instead of the noisy gRPC code prefix.

- **gateway-requirements.md**: Add GW-0401 criterion 6 requiring that
  verification failure diagnostics include per-instruction verifier notes.

- **gateway-design.md**: Document that \IngestProgram\ RPC errors carry
  forward-analysis diagnostics (GW-0401 criterion 6).

- **test**: \ingest_elf_verification_failure_includes_diagnostics\ asserts
  that a failing program produces multi-line output with verifier notes.

Closes #530

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: promote verification diagnostics to standalone GW-1305 requirement

Move verification failure diagnostics from GW-0401 AC#6 to a standalone
observability requirement GW-1305 in the operational-logging section.

- Add GW-1305 with acceptance criteria covering instruction-level
  diagnostics, `--verbose` CLI output, and summary fallback.
- Add T-1305a / T-1305b validation entries and traceability row.
- Update gateway-design.md cross-reference from GW-0401 criterion 6
  to GW-1305.
- Strength... (continued)

60 of 107 new or added lines in 2 files covered. (56.07%)

22799 of 26601 relevant lines covered (85.71%)

158.79 hits per line