firezone / firezone / 23660203923

67%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(portal): replace node type with dynamic pools (#12668)

## Summary

Removes `NODE_TYPE` and `BACKGROUND_JOBS_ENABLED` environment variables
("node coloring"), collapsing all node types into a single type. This
lets us run fewer VMs and reduce unnecessary cluster size — every node
now runs everything instead of needing separate web, API, and worker
nodes.

Since all processes now share the same VM, we introduce **two isolated
DB connection pools** to prevent noisy-neighbor effects between web and
API workloads:

- **Web** (`Portal.Repo.Web` / `Portal.Repo.Replica.Web`) — PortalWeb
HTTP requests and LiveViews
- **Api** (`Portal.Repo.Api` / `Portal.Repo.Replica.Api`) — PortalAPI
REST endpoints and channel/socket connections

Oban workers use the default `Portal.Repo` / `Portal.Repo.Replica` pool
— no separate Job pool needed.

Each pool has independent primary and replica repos (4 total), with
configurable pool sizes via new env vars.

### How pool routing works

Pool selection happens at process boundaries via `put_dynamic_repo/1`:

| Boundary | Mechanism | Pool |
|---|---|---|
| PortalWeb HTTP requests | `PortalWeb.Plugs.PutDynamicRepo` plug | Web
|
| PortalWeb LiveViews | `PortalWeb.LiveHooks.PutDynamicRepo` on_mount
hook | Web |
| PortalAPI HTTP requests | `PortalAPI.Plugs.PutDynamicRepo` plug | Api
|
| PortalAPI sockets | `connect/3` in each socket module | Api |
| Oban workers | (none — uses default `Portal.Repo`) | Default |

All DB access goes through `Portal.Safe` → `Portal.Repo` → Ecto's
`get_dynamic_repo/0`, which transparently dispatches to whichever pool
was set for the current process.

### Process hierarchy inheritance

Child processes (channel servers, tasks, GenServers) automatically
inherit their parent's pool via an overridden `get_dynamic_repo/0` on
`Portal.Repo` and `Portal.Repo.Replica`. This walks `$callers` and
`$ancestors` using `:erlang.process_info(pid, :dictionary)` to find the
parent's dynamic repo setting, then cach... (continued)

Coverage Stats

43 of 63 new or added lines in 15 files covered. (68.25%)

1 existing line in 1 file now uncovered.

35870 of 53376 relevant lines covered (67.2%)

473515.24 hits per line