23656477156
99%

Ran 27 Mar 2026 04:37PM UTC

Jobs 1

Files 138

Run time 1min

Badge

Embed ▾

Committed 27 Mar 2026 04:25PM UTC coverage: 98.66% (+0.01%) from 98.646%

Build # 23656477156

Build Type

push

github

Committed by

web-flow

Commit Message

[fix] Fixed duplicate template entries in Device admin

Bug:
The JS logic in relevant_templates.js assumed that the last
`ul.sortedm2m-items` element belonged to the empty inline form used by
Django admin formsets. This assumption breaks when the user does not
have permission to add Config objects: in that case the
ConfigInlineAdmin does not render the empty form.

As a result, both selectors ended up referencing the same list and the
script appended template elements twice to the same `sortedm2m` list,
causing duplicate entries and issues when saving the form.

Fix:
Select the empty form container explicitly using `#config-empty
ul.sortedm2m-items` instead of relying on the last occurrence of
`ul.sortedm2m-items`. This ensures the logic works correctly regardless
of whether the empty inline form is rendered.

[backport 1.2]

Run Details

7287 of 7386 relevant lines covered (98.66%)

10.85 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	python- - 23656477156.1	27 Mar 2026 04:37PM UTC	138	98.66	GitHub Action Run

openwisp / openwisp-controller / 23656477156
99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 23656477156

openwisp / openwisp-controller / 23656477156 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 23656477156

openwisp / openwisp-controller / 23656477156
99%

README BADGES
x