Ouranosinc / xscen / 23654763043

90%

Build Type

push

github

Committed by web-flow

Commit Message

Fix Pandas 3 change when reading list of variables from files after parsing variables as strings (#703)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

This is a pattern used for MRCC monthly files. The file name contains a
variable name, but the file itself contains more than that. Thus,
"variable" appears in the pattern and is parsed, but to have all
variables, we read them from file with this argument :
`read_from_file=[['variable', ...], ['variable']]`.

Since Pandas 3, a new StringDType exists, for the result of the first
filenames parsing has a `variable` column of this dtype. And when
setting an element to a tuple, it fails. Earlier, it was an Object
dtype, so there were no issue.

The fix simply changes the dtype of the column on the fly when this
situation happens.

### Does this PR introduce a breaking change?
No.


### Other information:

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

3 existing lines in 1 file now uncovered.

4374 of 4873 relevant lines covered (89.76%)

4.48 hits per line