nagayon-935 / mping / 23640233132

83%

push

github

fix(pinger): prevent concurrent traceroutes from sharing the same traceID

When multiple targets run traceroute concurrently, time.Now().Nanosecond()
can return the same value for goroutines that start nearly simultaneously,
causing all of them to generate the same traceID.

Since broadcastTrace fans out every received ICMP packet to all registered
traceCh channels, and acceptPacket filters by traceID, a collision meant
every traceroute accepted responses meant for the first target — making all
traceroutes appear to reach the same host.

Fix 1: Replace time-based traceID with an atomic counter per Pinger so each
concurrent TraceRoute call gets a strictly unique ID.

Fix 2: Remove the "if !ok { accept }" fallback in acceptPacket for
ICMPTypeTimeExceeded. Packets whose ID/seq cannot be extracted should be
rejected, not accepted without verification.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

1 of 1 new or added line in 1 file covered. (100.0%)

2568 of 3092 relevant lines covered (83.05%)

0.97 hits per line