kubeovn / kube-ovn / 23633945170

24%

Build Type

push

github

Committed by web-flow

Commit Message

feat(controller): support per-pod NIC granular DHCP control via annotations (#6475)

* feat(controller): support per-pod NIC granular DHCP control via annotations

Allow pod annotations to override subnet-level DHCP settings at the
per-LSP (logical switch port) granularity. Annotations follow the
provider-prefixed format:
  <provider>.kubernetes.io/dhcp-v4-options
  <provider>.kubernetes.io/dhcp-v6-options

Key behaviors:
- Pod annotation takes highest priority and overrides subnet enableDHCP
- Supports multi-NIC (Multus) by scoping annotations per provider name
- Override semantics: annotation completely replaces subnet-level DHCP
- GC extended to clean up orphaned per-port DHCP_Options entries
- reconcilePodDHCPOptions handles annotation changes on running pods

Implementation:
- Unified internal OVN DHCP_Options helpers (portName="" = subnet-level,
  portName!="" = per-port) to eliminate code duplication
- Added PortKey ExternalID to discriminate per-port from subnet entries
- Extracted getSubnetMTU() helper for reuse across controllers
- Added SetLogicalSwitchPortDHCPOptions for targeted LSP DHCP field update

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(controller): address review issues in per-pod DHCP options

Fix all issues raised in code review:

Bug fixes:
- Fix error messages: "logical router name" -> "logical switch name"
- Add portName validation in DeleteDHCPOptionsForPort to prevent
  accidentally deleting all per-port entries when portName is empty
- Add lsName/portName validation and dual-stack bounds check in
  UpdateDHCPOptionsForPort
- Fix per-family override semantics: on dual-stack subnets, only create
  per-port DHCP_Options for families with a non-empty annotation value;
  fall back to subnet-level UUIDs for un-annotated families
- Add missing nil assertion in GetDHCPOptions isolation test

Improvements:
- Add no-op fast path in SetLogicalSwitchPortDHCPOptions to avoid
  unnecessary OVN NB transactions when DHCP ... (continued)

Run Details

154 of 321 new or added lines in 5 files covered. (47.98%)

1 existing line in 1 file now uncovered.

13476 of 55678 relevant lines covered (24.2%)

0.28 hits per line