Grinkers / clojure-reader / 23632796040

99%

Build Type

push

github

Committed by web-flow

Commit Message

[Feature] Position-aware Parsing  (#7)

* Expose mod `parse` when flag 'unstable' is enabled

* Parsing of alternative position-aware syntax-tree `Node`

parse.rs:
- add structs `Position`, `Span`, `SourceReader`
- refactor out `line`, `column` & `ptr` fields of `Walker` to be
`SourceReader`'s responsibility, which sits as a mutable reference in
`Walker`'s field `reader`
- add enum `Node` which represents a concrete syntax-tree with span
information, and stores Maps and Sets as unprocessed lists
- modify  `parse` to parse a `Node` from a `SourceReader`
- remove `PartialEq` & `Eq` derives of `ParseContext` because they were
being used for a pattern-match (L448) that doesn't require it
- make `parse_element` work on `ParseReader` since it doesn't require
other `Walker` fields
- make `parse_char` directly return a char since it construct no other
`Node`/`Edn` variant, this makes it so we don't need to pass a `span`
parameter to it
- move `nibble_next()` call in `handle_close_delimiter` from after
matching over popped context, to be in each arm of that match (L404), so
as to let spans include closing delimiter, without moving it before the
`pop_context()` call for consistency

error.rs:
- method `Error::from_position` to construct an error directly from a
`parse::Position`

edn.rs:
- add `TryFrom` impl to convert a `Node` to an `Edn`, while processing
Maps and Sets (checks for duplicate keys and items respectively)
- update occurrences of `parse::parse` with parse::`parse_as_edn`

* Doc-comment spelling mistake

* clippy fix also results in full coverage

* README note + Allow `clippy::missing_errors_doc` when using the unstable feature.

* Add discarded forms to Node

- separated Node into NodeKind & Node
- add struct Discard containing a Node and also having its own span
- each Node may be preceded with any number of discarded nodes,
additionally collections (Vec, Map, Set, List) may contain any number of
trailing discarded nodes, which are stored in th... (continued)

Coverage Stats

272 of 278 new or added lines in 3 files covered. (97.84%)

1 existing line in 1 file now uncovered.

1111 of 1141 relevant lines covered (97.37%)

303.01 hits per line