Azure / ARO-RP / 23626685081

37%

push

github

Fix goroutine leak in monitor workOne due to unbuffered channel (#4714)

* Fix goroutine leak in monitor workOne due to unbuffered channel

When the 50s context timeout fires, workOne returns but the execute
goroutine blocks forever on sending to the unbuffered allJobsDone
channel, since no receiver is waiting anymore. This leaks the goroutine
and the entire Monitor struct (K8s clientsets, HTTP connection pools,
TLS state) on every timeout.

Buffering the channel with capacity 1 allows execute to send and exit
even when workOne has already returned.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add regression test for execute goroutine leak on timeout path

TestExecuteReturnsWhenNoReceiver simulates the workOne timeout scenario:
context is cancelled and nobody reads from the done channel. With the
previous unbuffered channel, execute would block forever on done <- true.
With the buffered channel fix, execute returns promptly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

1 of 1 new or added line in 1 file covered. (100.0%)

27372 of 73420 relevant lines covered (37.28%)

0.42 hits per line