google / recaptcha / 23616717473

100%

push

github

fix: Accept HTTP/1.1 responses in SocketPost to support proxies (#616)

* fix: accept HTTP/1.1 responses in SocketPost to support proxies

Proxies and certain hosting environments may convert outbound HTTP/1.0
requests and respond with HTTP/1.1 200 OK. The previous strict check
(strpos for 'HTTP/1.0 200 OK') caused false E_BAD_RESPONSE errors for
these users.

Replace the strpos check with a regex that accepts both HTTP/1.0 and
HTTP/1.1 200 OK response headers. Add a dedicated test to verify
HTTP/1.1 responses are handled correctly.

* test: verify SocketPost correctly rejects HTTP/1.1 errors

* test: verify SocketPost correctly rejects unsupported HTTP protocols

1 of 1 new or added line in 1 file covered. (100.0%)

158 of 158 relevant lines covered (100.0%)

20.03 hits per line