yext / search-ui-react / 23605733489

84%

Build Type

push

github

Committed by web-flow

Commit Message

chore: upgrade mapbox-gl version for accessibility issues (v3.0.0) (#654)

- current version has some accessibility issues that will be addressed by this upgrade
- removed unnecessary @types/mapbox-gl import since mapbox-gl provides its own types
- replace Mapbox-owned public types in search-ui-react with library-owned, version-stable interfaces
- replace deprecated Mapbox aliases usage
This PR also includes some improvements that I noticed when testing:
- test-site pin popups not showing up
- clean up the map listeners properly
- memoizes the debounced function so it stays the same across renders unless milliseconds changes

J=WAT-5461
TEST=auto,manual

verified test-site still function as expected
verified that locator functions as expected and that there is no longer any accessibility errors on live site

Run Details

1066 of 1476 branches covered (72.22%)

Branch coverage included in aggregate %.

73 of 97 new or added lines in 3 files covered. (75.26%)

1 existing line in 1 file now uncovered.

2330 of 2545 relevant lines covered (91.55%)

125.9 hits per line