Qiskit / qiskit / 23601954718

87%

main: 87%

Build Type

Pull #15884

github

Committed by mergify[bot]

Commit Message

Fix: `BasisTranslator` processing of nested `ControlFlowOp` (#15875)

* Fix: `BasisTranslator` processing of `ControlFlowOp`
- Remove the bool output `is_updated` from `apply_translation` helper method in `BasisTranslator`.
    The removal of this argument ensures that when a translation is found it is always applied. The `is_modified` boolean output, while intended as a way of optimizing the operation of the `BasisTranslator` did not achieve much as a new `DAGCircuit would be created each time.
    During the `ControlFlowOp` handling step of this method we relied on `is_updated` to determine whether to use the original `DAGCircuit` or not, which in the end would erroneously skip certain transformations in the `Operation`'s blocks.
    By removing this tracking value, which was already ignored by the main `BasisTranslator` process. We end up with a more correct processing of the instructions at hand.
- Update test `test_inner_wire_map_control_op` from the `TestCircuitControlFlowOps` as better outcome is now found for said circuit.

* Test: Add test
- Inspired on [comment](https://github.com/Qiskit/qiskit/issues/13162#issuecomment-2356920956) from @jakelishman.

* Docs: Add release note

* Address review comments:
- Add new test using a backend and the full transpiler pipeline.
- Add all issues to release note.
- Small language fix.

* Lint: formatting

* Fix: Make new test use aer

* Update releasenotes/notes/fix_basis_control_flow-033ecba233d5f9ed.yaml

Co-authored-by: Julien Gacon <gaconju@gmail.com>

---------

Co-authored-by: Julien Gacon <gaconju@gmail.com>
(cherry picked from commit 9c8f4fc53)

Pull Request Pull Request #15884: Fix: `BasisTranslator` processing of nested `ControlFlowOp` (backport #15875)

Coverage Stats

5 of 5 new or added lines in 1 file covered. (100.0%)

23 existing lines in 6 files now uncovered.

103549 of 118664 relevant lines covered (87.26%)

1002088.08 hits per line