gefyrahq / gefyra / 23596250822

74%

push

github

Go 1020 (#915)

* fix: break infinite loop when HPA scales during mount install

When HPA changes the replica count while a GefyraBridgeMount is in
INSTALLING or PREPARING, the mount gets stuck forever: ready() requires
matching pod counts between original and shadow workloads, but the
shadow still has the old count.

Add replica count mismatch detection to prepared() and route to restore
instead of retrying install when a mismatch is found. This sends the
mount back through RESTORING → PREPARING, which re-clones the workload
with the correct replica count.

- Add installing → restoring and preparing → restoring transitions
- Detect replica count divergence in prepared()
- Handler checks prepared() before install(), sends restore on mismatch
- Add unit tests covering HPA scale scenarios

* style(#GO-1020): apply ruff formatting to handler and tests

* fix(#GO-1020): limit prepared() circuit breaker to INSTALLING state only

In PREPARING, pod count differences are expected — shadow pods are still
starting up. The existing @install.cond guard handles this via
TemporaryError retries until pods are ready.

The circuit breaker (prepared() → restore) is only needed in INSTALLING,
where a pod count mismatch means HPA scaled the original workload and
the mount is genuinely stuck.

417 of 836 branches covered (49.88%)

Branch coverage included in aggregate %.

4643 of 5984 relevant lines covered (77.59%)

1.02 hits per line