kubeovn / kube-ovn / 23583440393

24%

push

github

fix(controller): clean orphaned attachment IPs on KubeVirt NAD hotplug (#6519)

* fix(controller): clean orphaned attachment IPs on KubeVirt NAD hotplug

When KubeVirt VEP #140 (LiveUpdateNADRef) changes a VM's secondary
network NAD reference, the old attachment IP CR and OVN LSP were never
released because keepIPCR=true (VMI still alive). This caused IP leaks
and orphaned OVN logical switch ports.

Add getVMOrphanedAttachmentPorts() to detect attachment networks on
a VM pod that are no longer in the VM's spec.template.spec.networks.
In the keepIPCR=true branch of handleDeletePod, selectively delete
orphaned attachment LSPs and release their IPs, while preserving the
shared primary network LSP and other unchanged attachment IPs.

Only vm.Spec.Template.Spec.Networks is used as the authoritative source
(not template annotations) because VEP #140 modifies spec.networks
and template annotations may not be synced.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(controller): also clean stale attachment IPs on new VM pod creation

Address review feedback: the orphaned attachment cleanup in
handleDeletePod only works when the NAD change happens before pod
deletion. In the stop→patch NAD→start workflow, the old pod deletion
is processed before the NAD patch, so stale IPs are missed.

Add cleanStaleVMAttachmentIPs() in reconcileAllocateSubnets to detect
and remove attachment LSPs/IPs that belong to the VM but are not part
of the current pod's networks. This ensures stale resources are cleaned
regardless of operation ordering.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(controller): address review feedback on stale IP cleanup robustness

1. cleanStaleVMAttachmentIPs now calls getPodKubeovnNets... (continued)

0 of 126 new or added lines in 1 file covered. (0.0%)

13343 of 55390 relevant lines covered (24.09%)

0.28 hits per line