benwbrum / fromthepage / 23565668440

72%

push

github

Fix admin owner list sorting and performance issues (#5280)

* Initial plan

* Remove slow active_page_count column from admin owner list

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Fix sorting to toggle between ASC/DESC and add last_sign_in_at sorting

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Add comprehensive tests for owner_list sorting functionality

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Add validation for sort direction and improve empty date display

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Improve SQL safety and code maintainability per code review

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Add clarifying comment about created_at in sort whitelist

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Fix rubocop linting errors (trailing whitespace)

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Merge development branch and fix duplicate login test failures

- Remove hardcoded login values ('alice', 'bob', 'charlie') from test fixtures
- Let unique_user factory generate unique logins via SecureRandom.uuid
- Update login sorting tests to verify sort order without depending on specific values
- Merge latest changes from development branch

Co-authored-by: saracarl <708566+saracarl@users.noreply.github.com>

* Remove tests that don't make any sense

* Remove pry

* Fix account type sort direction to match original behavior

The test expects account type to sort descending by default (as it did before),
showing "Trial", "Small Organization", "Legacy", then nil values.
Changed account_type_dir default from 'asc' to 'desc' to fix test failure.

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>
Agent-Logs-Url: https://github.com/benwbrum/fromthepage/sessions/07e115fd-421c-4837-9464-270e45be211f

* Merge development branch and resolve conflicts

... (continued)

2469 of 3965 branches covered (62.27%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 2 files covered. (100.0%)

10183 of 13659 relevant lines covered (74.55%)

151.06 hits per line