radio-t / stream-recorder / 23565677973

75%

Build Type

push

github

Committed by web-flow

Commit Message

Address issue #2: test bench, bug fixes, and code cleanup (#15)

* feat: consolidate server into single file and simplify

Merge health.go, index.go, download.go into server.go. Remove
over-engineered index struct (replaced with listEpisodes helper),
remove unused DownloadRecordHandler and /record/ route, parse
template once in NewServer. Remove unused revision param from
NewServer.

* feat: simplify recorder package and main.go

- Add doc comments explaining Client/Listener/Recorder data flow
- Rename myclient/streamlistener to client/listener/rec in main.go
- Add --dbg flag, replace revision == "local" debug logic
- Remove redundant os.IsNotExist check before MkdirAll
- Increase read buffer from 128 bytes to 32KB

* feat: fix context propagation in Recorder.Record

Record now checks ctx.Done() in the read loop and closes the stream
body on cancellation to unblock pending reads. Added tests for context
cancellation during recording and pre-cancelled context.

* feat: add server package tests

Add httptest-based tests for all server handlers:
- IndexHandler: lists episodes/files, empty dir, non-existent dir
- HealthHandler: valid dir (disk-capacity-dependent), non-existent dir
- DownloadEpisodeHandler: verifies zip contents and file data
- listEpisodes: unit tests for directory listing logic

* feat: extend integration tests with full pipeline and server verification

* feat: verify acceptance criteria and fix body close race condition

Fix race condition in Recorder.Record where stream body could be closed
concurrently by the context-cancellation goroutine and the defer. Use
sync.Once to ensure single close. All issue #2 feedback verified addressed,
tests pass with race detector, linter clean, coverage: recorder 83%, server 83%.

* feat: update README and comment on issue #2 with addressed feedback

fix: address code review findings

- fix path traversal vulnerability in DownloadEpisodeHandler (validate folder, check existence before headers)
- fix g... (continued)

Coverage Stats

139 of 183 new or added lines in 5 files covered. (75.96%)

1 existing line in 1 file now uncovered.

242 of 358 relevant lines covered (67.6%)

2.78 hits per line