stacklok / toolhive / 23555397829
65%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 579
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 65.316% (-0.1%) from 65.414%
23555397829

push

github

web-flow 
Add AuthServerConfig validation condition to VirtualMCPServer reconciler (#4350)

* Add inline AuthServerConfig validation to VirtualMCPServer reconciler

- Add RuntimeConfig and AuthServerConfig wrapper types to config model
  (runtime-only, not part of CRD schema)
- Set AuthServerConfigValidated condition in reconciler when inline
  AuthServerConfig is present on the spec
- Add E2E test for AuthServerConfigValidated condition lifecycle

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Extract AuthServerConfig validation into reconciler with full condition lifecycle

Move AuthServerConfig validation from Validate() into a dedicated
reconciler method that sets AuthServerConfigValidated condition on both
success (True) and failure (False), matching the pattern used by
validateGroupRef. This wires up the previously unused
ConditionReasonAuthServerConfigInvalid constant and clears stale
conditions when AuthServerConfig is removed from the spec.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Remove dead validateAuthServerConfig from types and fix unused receiver

The validateAuthServerConfig method on *VirtualMCPServer was only called
from tests — the real validation with condition lifecycle lives in the
reconciler. Remove the duplicate method and its test. Also drop the
unused receiver name on the reconciler method to fix the revive lint.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

11 of 59 new or added lines in 3 files covered. (18.64%)

45 existing lines in 7 files now uncovered.

51584 of 78976 relevant lines covered (65.32%)

72.58 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
8
18.46
 -1.21% cmd/thv-operator/pkg/virtualmcpserverstatus/mocks/mock_collector.go
40
65.49
 -1.5% cmd/thv-operator/controllers/virtualmcpserver_controller.go

Uncovered Existing Lines

Lines Coverage ∆ File
2
82.62
 -0.26% pkg/vmcp/composer/workflow_engine.go
2
71.43
 -1.68% pkg/vmcp/k8s/manager.go
2
51.71
 -0.19% pkg/workloads/manager.go
6
76.15
 -5.5% pkg/secrets/keyring/keyctl_linux.go
8
23.56
 -4.6% pkg/client/manager.go
11
68.42
 -14.47% pkg/client/discovery.go
14
74.44
 -5.19% pkg/client/config.go
Jobs
ID Job ID Ran Files Coverage
1 23555397829.1 579
65.32
 GitHub Action Run
Source Files on build 23555397829