hyperledger / fabric-x-committer / 23547454108

91%

Build Type

push

github

Committed by web-flow

Commit Message

[bft-delivery] BFT delivery (#427)

#### Type of change

- New feature
- Improvement (improvement to code, performance, etc)
- Breaking change
 
#### Description

**[BFT block delivery]**
- Introduce BFT (Byzantine Fault Tolerant) block delivery with block
withholding detection
- Use only the config block as the initialization mechanism (no separate
bootstrap config)
- Split the delivery package into 3:
- `deliver` (core library) - provides `ToQueue()` method for streaming
blocks to Go channels
- `deliverorderer` (BFT delivery from orderer) - implements
fault-tolerant delivery with verification and block withholding
detection
- `delivercommitter` (delivery from sidecar/ledger) - implements
delivery from peer ledger service (instead of `sidecarclient`)
- Replace the "client" notation with `ToQueue()` method that delivers to
a channel
- Move the `NewBroadcastStream()` method to loadgen package
(`loadgen/adapters/broadcast.go`) as it is the main use case for it

**[Test ENV]**
- Introduce a common `OrdererTestEnv` in `mock/test_exports.go` that
prepares the orderer and artifacts for tests
- Use it everywhere the Orderer is used for testing
- `MockOrderer` now receives `ArtifactsPath` instead of
`ConfigBlockPath` to support signing the blocks

**[ordererconn]**
- `LoadConfigBlock()/LoadConfigBlockFromFile()` now returns
`ConfigBlockMaterial` which includes:
  - Channel ID
  - Config block
  - Bundle
  - Orderer organizations with endpoints and CAs
  - Application organizations with CAs
- Remove connection manager (`conn_manager.go`) and replace with
`ConnectionMaterial` struct
- Add `OrdererConnectionMaterial()` method which returns
`connection.ClientMaterial` instances to connect to the orderer
- Add comprehensive tests: `config_test.go`, `identity_test.go`,
`load_test.go`

**[connection]**
- Introduce `ClientMaterial` struct for connection configuration without
YAML config:
  - Contains `Endpoints`, `TLS`, and `Retry` fields
  - Factory method `NewClien... (continued)

Run Details

866 of 937 new or added lines in 23 files covered. (92.42%)

26 existing lines in 7 files now uncovered.

10036 of 10973 relevant lines covered (91.46%)

41252.77 hits per line