stacklok / toolhive / 23545575683

65%

Build Type

push

github

Committed by web-flow

Commit Message

Merge runtime config override with defaults (#4304)

* Merge runtime config override with defaults

When --runtime-add-package is used without --runtime-image,
loadRuntimeConfig returned the override as-is with an empty
BuilderImage, producing an invalid Dockerfile ("FROM  AS builder").
Even with --runtime-image, AdditionalPackages replaced the defaults
instead of merging.

Additionally, the npx, go, and uvx templates only installed
AdditionalPackages in the builder stage. The runtime stage hardcoded
ca-certificates, so packages needed at runtime (e.g. git) were missing.

Fix both issues:
- Add mergeRuntimeConfig to fill empty BuilderImage from defaults and
  deduplicate-merge AdditionalPackages
- Update all three templates to install AdditionalPackages in the
  runtime stage

Fixes first half of #4301

* Update docs for runtime package impacting builder and runtime

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* docs generated

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: amirejaz <amir@stacklok.com>

Run Details

25 of 28 new or added lines in 2 files covered. (89.29%)

33 existing lines in 3 files now uncovered.

51440 of 78751 relevant lines covered (65.32%)

72.6 hits per line