kivy / kivy / 23536554603

60%

push

github

Fix mouse provider crash caused by obsolete alt_touch multitouch behavior (#9290)

Remove the alt_touch feature, which was a pre-multitouch-sim workaround
for interacting with Scatter using a mouse. It dispatched touches with
button=[] (a list), causing an AttributeError in ScrollView and any other
widget that calls touch.button.startswith(...). Right-click and
ctrl+left-click already provide complete multitouch simulation, making
the alt path redundant and broken.

Additional changes:
- Fix depack() args encoding bug: modifiers was packed at position 3 in
  the args tuple when do_graphics=False, causing multitouch_sim to be set
  to the modifiers list instead of a bool. Modifiers are now set directly
  on the touch object after creation, and 'modifiers' is always declared
  in the touch profile.
- Fix mutable default argument modifiers=[] in create_touch.
- Add explicit parentheses to on_mouse_release condition for clarity.
- Remove unused __handlers__ = {} class variable (cargo-culted from TUIO
  provider; never read or written in the mouse provider).
- Document ctrl+left-click and multitouch simulation behavior in the
  module docstring.
- Expand test suite from 20 to 26 tests: add coverage for ctrl+left,
  middle button, button='all' release, modifiers in touch profile, and
  modifiers attribute updates during drag.

Fixes: https://github.com/kivy/kivy/issues/9289

3022 of 6190 branches covered (48.82%)

124 of 124 new or added lines in 2 files covered. (100.0%)

25351 of 44376 relevant lines covered (57.13%)

1.12 hits per line