stacklok / toolhive / 23532991680

65%

Build Type

push

github

Committed by web-flow

Commit Message

fix: return 503 instead of 500 when upstream registry is unavailable (#4352)

* fix: return 503 instead of 500 when upstream registry is unavailable

When the configured registry API URL is wrong or the upstream registry
returns a non-auth error (404, timeout, connection refused), the GET
endpoints now return HTTP 503 with a structured JSON response containing
code "registry_unavailable" and the original error message, instead of
a generic 500 "Failed to get registry".

This follows the same pattern as the existing "registry_auth_required"
503 response, allowing clients to distinguish between auth issues and
upstream availability issues.

Fixes #4351

Made-with: Cursor

* fix: rename RegistryUnavailableError to UnavailableError to avoid stutter

Address golangci-lint revive and gci formatting issues:
- Rename RegistryUnavailableError → UnavailableError (registry.RegistryUnavailableError stutters)
- Fix struct field alignment formatting (gci)

Made-with: Cursor

* refactor: rename registryAuthErrorResponse to registryErrorResponse

The struct is now used for both registry_auth_required and
registry_unavailable 503 responses, so the name should be generic.

Made-with: Cursor

Run Details

24 of 49 new or added lines in 3 files covered. (48.98%)

193 existing lines in 4 files now uncovered.

51229 of 79989 relevant lines covered (64.05%)

148.44 hits per line