stacklok / toolhive / 23527159652
65%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 576
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 64.089% (-0.1%) from 64.208%
23527159652

push

github

web-flow 
Fix resource relay to preserve text/blob distinction (#4335)

* Fix resource relay to preserve text/blob distinction and per-item metadata

The vMCP resource relay had two bugs:

1. Binary corruption: all resources were forced into TextResourceContents
   with string(rawBytes), corrupting non-UTF-8 blob data that had been
   base64-decoded then re-stringified.

2. Multi-content flattening: ConcatenateResourceContents merged all items
   into a single []byte, losing per-item URIs and MIME types.

Replace the lossy []byte + MimeType representation with []ResourceContent
that preserves individual items with their text/blob distinction. Add
bidirectional converters (ConvertMCPResourceContents / ToMCPResourceContents)
and remove the old ConcatenateResourceContents function.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address review comments on resource relay PR

- Document Text/Blob invariant on ResourceContent struct (Blob takes
  precedence when both are set)
- Add discriminant comment in ToMCPResourceContents explaining the
  Blob-precedence logic
- Restore warn log level for unknown resource content types (dropping
  data should be visible to operators, not silenced at debug level)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

39 of 51 new or added lines in 5 files covered. (76.47%)

147 existing lines in 10 files now uncovered.

51044 of 79646 relevant lines covered (64.09%)

149.39 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
12
83.09
 1.69% pkg/vmcp/conversion/content.go

Uncovered Existing Lines

Lines Coverage ∆ File
2
71.43
 -1.68% pkg/vmcp/k8s/manager.go
3
83.09
 1.69% pkg/vmcp/conversion/content.go
4
51.9
 -0.19% pkg/workloads/manager.go
8
23.56
 -4.6% pkg/client/manager.go
10
83.5
 -3.3% pkg/vmcp/server/sessionmanager/session_manager.go
11
68.42
 -14.47% pkg/client/discovery.go
14
74.44
 -5.19% pkg/client/config.go
15
61.3
 -2.24% pkg/vmcp/client/client.go
24
66.34
 -5.24% pkg/vmcp/session/internal/backend/mcp_session.go
56
67.15
 -21.05% pkg/vmcp/server/adapter/handler_factory.go
Jobs
ID Job ID Ran Files Coverage
1 23527159652.1 576
64.09
 GitHub Action Run
Source Files on build 23527159652