stacklok / toolhive / 23527159652

73%

Build Type

push

github

Committed by web-flow

Commit Message

Fix resource relay to preserve text/blob distinction (#4335)

* Fix resource relay to preserve text/blob distinction and per-item metadata

The vMCP resource relay had two bugs:

1. Binary corruption: all resources were forced into TextResourceContents
   with string(rawBytes), corrupting non-UTF-8 blob data that had been
   base64-decoded then re-stringified.

2. Multi-content flattening: ConcatenateResourceContents merged all items
   into a single []byte, losing per-item URIs and MIME types.

Replace the lossy []byte + MimeType representation with []ResourceContent
that preserves individual items with their text/blob distinction. Add
bidirectional converters (ConvertMCPResourceContents / ToMCPResourceContents)
and remove the old ConcatenateResourceContents function.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address review comments on resource relay PR

- Document Text/Blob invariant on ResourceContent struct (Blob takes
  precedence when both are set)
- Add discriminant comment in ToMCPResourceContents explaining the
  Blob-precedence logic
- Restore warn log level for unknown resource content types (dropping
  data should be visible to operators, not silenced at debug level)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

39 of 51 new or added lines in 5 files covered. (76.47%)

147 existing lines in 10 files now uncovered.

51044 of 79646 relevant lines covered (64.09%)

149.39 hits per line